[AKS] BREAKING CHANGE: Update ACNS preview CLI commands to align with GA CLI

[rayaisaiah]

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --enable-acns
az aks create --enable-acns --disable-acns-observability
az aks create --enable-acns --disable-acns-security

az aks update --enable-acns
az aks update --disable-acns
az aks update --enable-acns --disable-acns-observability
az aks update --enable-acns --disable-acns-security

And removes

az aks create --enable-advanced-network-observability
az aks create --advanced-networking-observability-tls-management
az aks create --enable-fqdn-policy

az aks update --enable-advanced-network-observability
az aks update --disable-advanced-network-observability
az aks update --advanced-networking-observability-tls-management
az aks update --enable-fqdn-policy
az aks update --disable-fqdn-policy

To align with GA CLI commands for ACNS: Azure/azure-cli#30208.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
• My extension version conforms to the Extension version schema

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule	cmd_name	rule_message	suggest_message
❌ 1007 - ParaRemove	aks create	cmd aks create removed parameter advanced_networking_observability_tls_management	please add back parameter advanced_networking_observability_tls_management for cmd aks create
❌ 1007 - ParaRemove	aks create	cmd aks create removed parameter enable_advanced_network_observability	please add back parameter enable_advanced_network_observability for cmd aks create
❌ 1007 - ParaRemove	aks create	cmd aks create removed parameter enable_fqdn_policy	please add back parameter enable_fqdn_policy for cmd aks create
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter advanced_networking_observability_tls_management	please add back parameter advanced_networking_observability_tls_management for cmd aks update
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter disable_advanced_network_observability	please add back parameter disable_advanced_network_observability for cmd aks update
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter disable_fqdn_policy	please add back parameter disable_fqdn_policy for cmd aks update
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter enable_advanced_network_observability	please add back parameter enable_advanced_network_observability for cmd aks update
❌ 1007 - ParaRemove	aks update	cmd aks update removed parameter enable_fqdn_policy	please add back parameter enable_fqdn_policy for cmd aks update
⚠️ 1006 - ParaAdd	aks create	cmd aks create added parameter disable_acns_observability
⚠️ 1006 - ParaAdd	aks create	cmd aks create added parameter disable_acns_security
⚠️ 1006 - ParaAdd	aks update	cmd aks update added parameter disable_acns_observability
⚠️ 1006 - ParaAdd	aks update	cmd aks update added parameter disable_acns_security

[azure-client-tools-bot-prd]

Hi @rayaisaiah,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[azure-client-tools-bot-prd]

Hi @rayaisaiah,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[github-actions]

• For more info about extension versioning, please refer to Extension version schema

[FumingZhang]

Queued live test live test to validate the change, test passed!

• test_aks_update_enable_acns
• test_aks_create_with_enable_acns
• test_aks_create_with_enable_acns_complex

[rayaisaiah]

@FumingZhang i tried to requeue the live test but it looks like its failing at Set up Virtual Environment. Do you know how to resolve this?

[FumingZhang]

I've fixed the failed CI checks in #8229. Please rebase from main and choose a new major version (e.g., 11.0.0b1).

[rayaisaiah]

Rebased and requeue live tests which is passing now

[rayaisaiah]

hey @FumingZhang it looks like the azure-cli-extensions pipeline check is failing for Integration Tests, Build Tests Python38.Run integration test and build test and it looks unrelated to pr. Do you know why this is occuring?

[FumingZhang]

hey @FumingZhang it looks like the azure-cli-extensions pipeline check is failing for Integration Tests, Build Tests Python38.Run integration test and build test and it looks unrelated to pr. Do you know why this is occuring?

Yes, that's not related to your change.

[FumingZhang]

hey @FumingZhang it looks like the azure-cli-extensions pipeline check is failing for Integration Tests, Build Tests Python38.Run integration test and build test and it looks unrelated to pr. Do you know why this is occuring?

Yes, that's not related to your change.

Oh, the issue has been fixed in #8235. Please rebase from main to pick up this fix.

BTW, there's another breaking change #8228 going to take 11.0.0b1, maybe you'll need to take 12.0.0b1

[rayaisaiah]

hey @FumingZhang it looks like the azure-cli-extensions pipeline check is failing for Integration Tests, Build Tests Python38.Run integration test and build test and it looks unrelated to pr. Do you know why this is occuring?

Yes, that's not related to your change.

Oh, the issue has been fixed in #8235. Please rebase from main to pick up this fix.

BTW, there's another breaking change #8228 going to take 11.0.0b1, maybe you'll need to take 12.0.0b1

Updated

[rayaisaiah]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 8217 in repo Azure/azure-cli-extensions

[FumingZhang]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[yanzhudd]

please resolve the code conflict

[azclibot]

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204097&view=results