[Extension] fix loading wrong metadata for wheel type extension#13222
Merged
haroldrandom merged 3 commits intoAzure:devfrom Apr 28, 2020
Merged
[Extension] fix loading wrong metadata for wheel type extension#13222haroldrandom merged 3 commits intoAzure:devfrom
haroldrandom merged 3 commits intoAzure:devfrom
Conversation
Collaborator
|
add to S170 |
fengzhou-msft
approved these changes
Apr 28, 2020
Member
fengzhou-msft
left a comment
There was a problem hiding this comment.
verified locally with azure-iot.
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this #12782 merged, the ability to load metadata from a Python Package is enhanced, but the algorithm is to travel all folders under a specific extension home folder.
azure-cli/src/azure-cli-core/azure/cli/core/extension/__init__.py
Lines 146 to 151 in 69c9933
The problem is that if there are other folder named with
.dist-info, it will load their metadata too, which will show a wrong extension version. Such asazure-iotandalias, as it has dependecies and CLI will place those dependecies inside the same folder forazure-iot.That's why causing this bug.
Testing Guide
Before fix, try install
azure-iotextension, thenaz extension list -o tableit will show a wrong version instead of its current version0.9.1After fix, it will show
0.9.1History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.