{Extension} Enhance the ability to filter extension's dist-info in order to get correct METADATA #13251
Merged
haroldrandom merged 2 commits intoAzure:devfrom Apr 30, 2020
Conversation
haroldrandom
added
Core
haroldrandom
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
jiasli and
qianwens
as code owners
haroldrandom
changed the title
Collaborator
|
add to S169 |
fengzhou-msft
approved these changes
Apr 29, 2020
haroldrandom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fix #13222 here to filter extension's metadata has potention bugs.
azure-cli/src/azure-cli-core/azure/cli/core/extension/__init__.py
Line 141 in 154ecaa
If some dependecies have longer name and prefix with the extension name, it make still crash. Currently just lucky.
Besides, the current way to filter will still filter out those folders ends with
.egg-infowhich contains PKG-INFO instead of METADATA. So, it would crash due to incorrect metadata format forpkginfo.WheelFix #13241
Fix Azure/azure-iot-cli-extension#173
Fix #13240
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.