{REST} Only extract subscription ID for ARM requests#13782
Merged
Conversation
jiasli
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom and
qianwens
as code owners
jiasli
changed the title
Collaborator
|
add to S171 |
mmyyrroonn
approved these changes
Jun 4, 2020
| # https://management.azure.com/ + subscriptions/xxx/resourcegroups/xxx?api-version=2019-07-01 | ||
| if '://' not in url: | ||
| url = cli_ctx.cloud.endpoints.resource_manager + url.lstrip('/') | ||
| url = endpoints.resource_manager.rstrip('/') + url |
Contributor
There was a problem hiding this comment.
is this change necessary?
Member
Author
There was a problem hiding this comment.
No. Only for consistency and keep the resource ID intact.
Member
Author
|
Add @myronfanqiu as code owner for core as he is actively working on |
zhoxing-ms
approved these changes
Jun 5, 2020
Juliehzl
approved these changes
Jun 8, 2020
jiasli
changed the title
This was referenced Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix regression introduced in #13225.
az restnow only extracts subscription ID for ARM requests, not for AD Graph request.The ID (
00000002-0000-0000-0000-000000000000) in an AD Graph request (https://graph.windows.net/00000002-0000-0000-0000-000000000000/applications/00000003-0000-0000-0000-000000000000?api-version=1.6) is tenant ID. Using it as a subscription ID will cause failure inget_raw_token.Testing Guide