Skip to content

{REST} Add tests for az rest with Microsoft Graph#13849

Merged
jiasli merged 6 commits intoAzure:devfrom
jiasli:rest-graph
Jun 8, 2020
Merged

{REST} Add tests for az rest with Microsoft Graph#13849
jiasli merged 6 commits intoAzure:devfrom
jiasli:rest-graph

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Jun 5, 2020

Description
Add tests for az rest with Microsoft Graph.

Testing Guide
az rest --method {} --url https://graph.microsoft.com/v1.0/... --body '{}'

@jiasli jiasli self-assigned this Jun 5, 2020
@jiasli jiasli added this to the S171 milestone Jun 5, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 5, 2020

add to S171

@jiasli
Copy link
Member Author

jiasli commented Jun 8, 2020

Re-run tests to validate changes in #13782.

@jiasli jiasli changed the title [REST] Add tests for az rest with Microsoft Graph {REST} Add tests for az rest with Microsoft Graph Jun 8, 2020
Copy link
Member

@qianwens qianwens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

az rest --method put --uri https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/publicIPAddresses/{publicIpAddressName}?api-version=2019-09-01 --body @body.json
az rest --method put --url https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/publicIPAddresses/{publicIpAddressName}?api-version=2019-09-01 --body @body.json
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--uri /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}?api-version=2019-03-01
--url https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/publicIPAddresses/{publicIpAddressName}?api-version=2019-09-01

So our current specification is that if it's a URL parameter we should use --url, and if it's not a URL parameter we should use --uri, right?

@jiasli jiasli merged commit 5dca36a into Azure:dev Jun 8, 2020
@jiasli jiasli deleted the rest-graph branch June 8, 2020 06:26
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants