Skip to content

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Jul 9, 2020

Description

fix issue #13876, #14240

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan requested review from qianwens and zhoxing-ms July 9, 2020 07:46
@yonzhan yonzhan added this to the S173 milestone Jul 9, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 9, 2020

Storage

@Juliehzl Juliehzl requested review from arrownj and jiasli as code owners July 9, 2020 09:11
@Juliehzl Juliehzl merged commit 6127cd5 into Azure:dev Jul 10, 2020
@Juliehzl Juliehzl deleted the storage-package branch July 23, 2020 02:45
except Exception as ex: # pylint: disable=broad-except
exceptions['load_commands'] = ex
logger.error('Error occurred loading commands!\n')
raise ex
Copy link
Member

@jiasli jiasli Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raise ex makes this function exit, thus exceptions is no longer checked and useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants