Skip to content

Conversation

@haroldrandom
Copy link
Contributor

Description

Follow up of #14295

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@haroldrandom haroldrandom added this to the S173 milestone Jul 15, 2020
@haroldrandom haroldrandom self-assigned this Jul 15, 2020
@haroldrandom haroldrandom requested a review from Juliehzl July 15, 2020 05:38
@haroldrandom haroldrandom marked this pull request as ready for review July 15, 2020 05:42
@jiasli
Copy link
Member

jiasli commented Jul 15, 2020

Why did we change the logic to fail immediately instead of show the failures after all are finished?

@haroldrandom
Copy link
Contributor Author

haroldrandom commented Jul 15, 2020

Why did we change the logic to fail immediately instead of show the failures after all are finished?

Detail in the linked PR. The aggregated exceptions would not display the tracestack

@jiasli
Copy link
Member

jiasli commented Jul 16, 2020

The aggregated exceptions would not display the tracestack

traceback.format_exc can do this job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants