{CI} Use azdev to honor local pylint and flake8 configuration#14402
Merged
{CI} Use azdev to honor local pylint and flake8 configuration#14402
Conversation
haroldrandom
requested review from
Juliehzl,
arrownj,
bgklein,
bim-msft,
fengzhou-msft,
jiasli,
jsntcy,
mmyyrroonn,
qianwens,
qwordy and
zhoxing-ms
as code owners
Contributor
Author
|
/azp run |
|
Pull request contains merge conflicts. |
haroldrandom
force-pushed
the
fix-code-style
branch
from
82473d7 to
d5e2614
Compare
Collaborator
|
CI |
added 2 commits
July 18, 2020 20:18
2 tasks
added 2 commits
July 20, 2020 10:10
fengzhou-msft
approved these changes
Jul 20, 2020
haroldrandom
changed the title
jiasli
approved these changes
Jul 20, 2020
mmyyrroonn
reviewed
Jul 20, 2020
| elif hour >= 10: | ||
| value = '+{}'.format(hour) | ||
| elif hour < 0 and hour > -10: | ||
| elif -1 < hour < 0: |
Contributor
There was a problem hiding this comment.
Shout it be -10 instead of -1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
with this PR Azure/azure-cli-dev-tools#219 merged, azdev is going to hornor the repo local pylint and flake8 configuration
Fix Azure/azure-cli-dev-tools#209
Testing Guide
The only difference between this PR and #14419 is the
azure-pipeline.yamlHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.