Skip to content

{CI} Test fix code style#14419

Closed
haroldrandom wants to merge 6 commits intoAzure:devfrom
haroldrandom:test-fix-code-style
Closed

{CI} Test fix code style#14419
haroldrandom wants to merge 6 commits intoAzure:devfrom
haroldrandom:test-fix-code-style

Conversation

@haroldrandom
Copy link
Contributor

Description

The test result of #14402

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

set -ev
. env/bin/activate

pip install --force -q git+https://github.com/Azure/azure-cli-dev-tools.git@master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the different between this PR and #14402

@yonzhan yonzhan added this to the S173 milestone Jul 20, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 20, 2020

CI

Copy link
Member

@qwordy qwordy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve vm part

set -ev
. env/bin/activate

pip install --force -q git+https://github.com/Azure/azure-cli-dev-tools.git@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we using the PyPI version of azdev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This PR just for verifying the result, the feature is still in the master branch of azdev. I will release a newer azdev once #14402 is megred.

@haroldrandom haroldrandom marked this pull request as draft July 20, 2020 06:07
@haroldrandom
Copy link
Contributor Author

Close as the related one is merged

@haroldrandom haroldrandom deleted the test-fix-code-style branch July 20, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants