[ARM] az tag support for resource id parameter#14558
Merged
zhoxing-ms merged 10 commits intoAzure:devfrom Jul 31, 2020
Merged
Conversation
2 tasks
Collaborator
|
ARM |
Contributor
|
@Grayer123 May I ask can PR #13429 be closed? |
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
hamidtirmizi
approved these changes
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
zhoxing-ms
reviewed
Jul 29, 2020
Juliehzl
reviewed
Jul 29, 2020
Juliehzl
reviewed
Jul 29, 2020
jsntcy
reviewed
Jul 30, 2020
jsntcy
reviewed
Jul 30, 2020
Contributor
Author
|
Could it be merged and add to S173 release please? @zhoxing-ms, @Juliehzl |
Juliehzl
reviewed
Jul 31, 2020
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Juliehzl
reviewed
Jul 31, 2020
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Jul 31, 2020
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a replacement for the existing pr: az tag support for -id parameter, as there are too many conflicts while merging the dev branch. Creating this pr to only include tags related changes.
We are working on expanding our tags related cli cmdlets, to be more specific, adding the following cmdlets:
At this stage, we are just supporting –-resourceid for all cmdlets, and they will look like as following:(supporting both --resourceid and -id)
We have the same design in the PowerShell cmdlet, please see this powershell design pr for more details.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.