Skip to content

{VM} Fix #14897: display all requirements for vm admin password when it's invalid #14902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houk-ms merged 5 commits into from
Sep 10, 2020
Merged

{VM} Fix #14897: display all requirements for vm admin password when it's invalid #14902

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eef77c9
improve vm password validation message
houk-ms Aug 25, 2020
4da2bcb
fix typo
houk-ms Aug 25, 2020
b7816b8
adjust error messages
houk-ms Sep 8, 2020
31b8847
adjsut error message
houk-ms Sep 8, 2020
3d108cb
fix testing issues
houk-ms Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/azure-cli/azure/cli/command_modules/vm/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,18 +1034,19 @@ def _validate_admin_password(password, os_type):
is_linux = (os_type.lower() == 'linux')
max_length = 72 if is_linux else 123
min_length = 12
if len(password) not in range(min_length, max_length + 1):
raise CLIError('The password length must be between {} and {}'.format(min_length,
max_length))

contains_lower = re.findall('[a-z]+', password)
contains_upper = re.findall('[A-Z]+', password)
contains_digit = re.findall('[0-9]+', password)
contains_special_char = re.findall(r'[ `~!@#$%^&*()=+_\[\]{}\|;:.\/\'\",<>?]+', password)
count = len([x for x in [contains_lower, contains_upper,
contains_digit, contains_special_char] if x])

# pylint: disable=line-too-long
if count < 3:
raise CLIError('Password must have the 3 of the following: 1 lower case character, 1 upper case character, 1 number and 1 special character')
error_msg = ("The password length must be between {} and {}. Password must have the 3 of the following: "
"1 lower case character, 1 upper case character, 1 number and 1 special character.").format(min_length, max_length)
if len(password) not in range(min_length, max_length + 1) or count < 3:
raise CLIError(error_msg)


def validate_ssh_key(namespace):
Expand Down