[AKS] FIX #12871: az aks enable-addons: Autogenerated help example is wrong for vitual-node option#14989
Conversation
Manual update of aks enable-addon command help text
Contributor
Author
|
Fixed PR title. |
Member
|
hi @mirdaki This is an auto-generated AKS example, but missing a parameter. Could you pls help to look at from Aladdin side also? Goal is that next Aladdin offline pacakge will not refresh this fixing, and will not happen. |
yungezz
approved these changes
Sep 1, 2020
arrownj
reviewed
Sep 1, 2020
| examples: | ||
| - name: Enable Kubernetes addons. (autogenerated) | ||
| text: az aks enable-addons --addons virtual-node --name MyManagedCluster --resource-group MyResourceGroup | ||
| text: az aks enable-addons --addons virtual-node --name MyManagedCluster --resource-group MyResourceGroup --subnet MySubnetName |
Contributor
There was a problem hiding this comment.
Why do we need to update this autogenereated example ?
Contributor
Author
There was a problem hiding this comment.
Because it doesn't contain all the required parameters. Please see #12871
Contributor
|
@yungezz I've looped in the rest of the Aladdin team to make sure this is addressed. |
Contributor
|
Hi @mirdaki , could you please update the PR title following Submitting Pull Requests |
haroldrandom
approved these changes
Sep 2, 2020
mikkelhegn
changed the title
Contributor
Author
|
@arrownj - updated PR title |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
arrownj
approved these changes
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual update of aks enable-addon command help text
Description
Fixes autogenerated help message for aks enable-addon. #12871
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.