[RDBMS] Breaking Change: Parameter name updates. Improvements to Management Plane for MySQL and PostgreSQL by mjain2 · Pull Request #15363 · Azure/azure-cli

mjain2 · 2020-09-30T06:23:13Z

Description

Note: Recreating this PR to update the history/rebase with hotfix changes for rdbms.

This PR improves existing commands for the 'Flexible Servers' APIs within the RDBMS component.

Breaking changes:
Parameter name changes

-- time to --restore-in-time for restore command
Why: PM requested change to make it clearer for customer. Documentation on our side will also be updated.
--force to --yes
Why: Consistency across different delete prompt commands for customer experience.
--server-name to --name for CRUD operations
Why: PM requested change for consistency
--name to --rule-name in firewall rule
Why: PM requested for clearer & self-explanatory params for customer experience.

Changes include:

Update MySQL Connection string in create command
Replace server name check with CheckNameAvailability API for MySQL & PostgreSQL
Update help text and parameters for commands to be more descriptive and helpful to user (commands/arguments: vnet related, replica, firewall, restore). These were to improve customer experience.
Update validators to use result from list-skus commands/API.
Enabled more tests for code coverage and command testing (validator & replica tests)
Added new recording files with default locations for MySQL & PostgreSQL

Testing Guide

To run tests (these cover existing commands and include new tests):
azdev test rdbms

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

ServerNameAvailability API to validate server names

…e-cli into mjain2/ppbugbash

Connect, test fixes, parameter and description updates

Rebasing on top of hotfix

mjain2 · 2020-09-30T06:23:30Z

Please merge this with a squash commit :)

yonzhan · 2020-09-30T10:19:00Z

RDBMS

Juliehzl · 2020-10-09T03:41:38Z

/azp run

azure-pipelines · 2020-10-09T03:41:43Z

Pull request contains merge conflicts.

src/azure-cli/azure/cli/command_modules/rdbms/_helptext_mysql.py

Juliehzl · 2020-10-16T06:38:04Z

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

            c.argument('server_name', id_part='name', options_list=['--name', '-n'], arg_type=server_name_getter_arg_type)
-            c.argument('force', options_list=['--force'], action='store_true',
-                       help='Delete the server without prompt')
+            c.argument('yes', options_list=['--yes', '-y'], action='store_true',


renaming parameters name is breaking change. could you explain why we need such renaming?

we wanted to deleting align confirmation parameters same as deleting commands of other resources

@Juliehzl have updated the PR description to reflect these changes. Our new service was just rolled out last week so usage is still low, so there is relatively low risk.

src/azure-cli/azure/cli/command_modules/rdbms/_params.py

Juliehzl · 2020-10-20T08:15:37Z

could you refine description part according to https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests?

mjain2 · 2020-10-20T08:31:12Z

could you refine description part according to https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests?

Made the update thanks!

Juliehzl

Approve for the breaking change because there is little usages in past 30 days and service team request

DaeunYim and others added 28 commits September 18, 2020 16:40

validate with list-skus info

6c7d7b3

style fixed

f4aff33

validate with list-skus info

341fbcf

style fixed

9207f45

move validators to command body to speed up

9caa763

test code for validator and restored mgmt testcode

8d9f96c

resolve conflicts

72e34f9

minor fix

27a273b

flexible mgmt mysql test

7848a49

new test recording files

7e61dad

deleting arguments and recording files modified

490908d

style fixed, location changed, linter fixed

33c038f

Adding az {} flexible-server connect capability

b7f7ed0

Styling and linter fixes

6795970

Merging with ppbugbash

63add36

firewall rule name generation and end-ip-address rule changed

aa3c7e8

style fixed

dca3e63

restore removed sterling test

8d16183

Fixing tests for renaming of parameters

47f489f

post public preview changes

5249876

remove point in time param name change

40d4d76

Merge pull request #2 from DaeunYim/arde/ppplusone

f1c1396

ServerNameAvailability API to validate server names

Merge branch 'daeunyim/ppbugbash' of https://github.com/DaeunYim/azur…

01d284b

…e-cli into mjain2/ppbugbash

Merge pull request #1 from DaeunYim/mjain2/ppbugbash

abaab72

Connect, test fixes, parameter and description updates

Fixing linter/style issues and connect libraries in setup.py

98c4775

Removing connect capability due to package issue

adcb404

Merge with dev

307e9aa

Merge pull request #3 from DaeunYim/daeunyim/ppbugbash

0e3f9c7

Rebasing on top of hotfix

Removing connect packages from windows.txt

4c908e9

DaeunYim approved these changes Sep 30, 2020

View reviewed changes

mjain2 mentioned this pull request Sep 30, 2020

[RDBMS] Improvements to Management Plane for MySQL and PostgreSQL #15358

Closed

2 tasks

yonzhan requested a review from Juliehzl September 30, 2020 10:19

yonzhan assigned Juliehzl Sep 30, 2020

yonzhan added this to the S177 milestone Sep 30, 2020

yonzhan requested review from jsntcy and zhoxing-ms September 30, 2020 10:19

mjain2 requested a review from haroldrandom as a code owner October 7, 2020 21:21

DaeunYim force-pushed the dev branch 2 times, most recently from e17a251 to 468dff9 Compare October 7, 2020 21:55

DaeunYim added 2 commits October 8, 2020 15:20

flexible server tests and new recording files

5812e7d

adding create test with different tiers and sku

377a6af

DaeunYim and others added 2 commits October 9, 2020 13:55

Merge branch 'dev' into dev

6f28532

style issue fixed

c9849a7

mjain2 force-pushed the dev branch from 69d79b5 to c9849a7 Compare October 13, 2020 21:42

mjain2 added 2 commits October 15, 2020 14:08

Trigger pipeline

989476d

Trigger pipeline

2e20afd

DaeunYim mentioned this pull request Oct 16, 2020

[RDBMS] Add List-SKUS Command, Table Transformers, Local Context for Postgres, MySQL, Mariadb Single Server #15450

Merged

2 tasks

Juliehzl reviewed Oct 16, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/rdbms/_helptext_mysql.py Show resolved Hide resolved

Juliehzl reviewed Oct 16, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/rdbms/_params.py Show resolved Hide resolved

Juliehzl reviewed Oct 16, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/rdbms/_params.py Show resolved Hide resolved

mjain2 changed the title ~~[RDBMS] Improvements to Management Plane for MySQL and PostgreSQL~~ [RDBMS] Breaking Change: Parameter name updates. Improvements to Management Plane for MySQL and PostgreSQL Oct 20, 2020

Juliehzl approved these changes Oct 22, 2020

View reviewed changes

Juliehzl merged commit 0c54416 into Azure:dev Oct 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RDBMS] Breaking Change: Parameter name updates. Improvements to Management Plane for MySQL and PostgreSQL#15363

[RDBMS] Breaking Change: Parameter name updates. Improvements to Management Plane for MySQL and PostgreSQL#15363
Juliehzl merged 36 commits intoAzure:devfrom
DaeunYim:dev

mjain2 commented Sep 30, 2020 •

edited

Loading

Uh oh!

mjain2 commented Sep 30, 2020

Uh oh!

yonzhan commented Sep 30, 2020

Uh oh!

Juliehzl commented Oct 9, 2020

Uh oh!

azure-pipelines bot commented Oct 9, 2020

Uh oh!

Uh oh!

Juliehzl Oct 16, 2020

Uh oh!

DaeunYim Oct 16, 2020

Uh oh!

mjain2 Oct 20, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Juliehzl commented Oct 20, 2020

Uh oh!

mjain2 commented Oct 20, 2020

Uh oh!

Juliehzl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mjain2 commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjain2 commented Sep 30, 2020

Uh oh!

yonzhan commented Sep 30, 2020

Uh oh!

Juliehzl commented Oct 9, 2020

Uh oh!

azure-pipelines bot commented Oct 9, 2020

Uh oh!

Uh oh!

Juliehzl Oct 16, 2020

Choose a reason for hiding this comment

Uh oh!

DaeunYim Oct 16, 2020

Choose a reason for hiding this comment

Uh oh!

mjain2 Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Juliehzl commented Oct 20, 2020

Uh oh!

mjain2 commented Oct 20, 2020

Uh oh!

Juliehzl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mjain2 commented Sep 30, 2020 •

edited

Loading

mjain2 Oct 20, 2020 •

edited

Loading