[Packaging] Support ARM64 on Linux by bebound · Pull Request #24180 · Azure/azure-cli

bebound · 2022-10-13T07:42:55Z

Description

The long-awaited feature is finally here. The ARM64 build will be released for current supported Linux distribution.

Close #7368

Related issue: #22875

Main changes:

Artifact folder adds -amd64 or -arm64 suffix.
Deb packages suffixes change from all.deb to amd64.deb/arm64.deb.
Deb packages size decreases by 20MB and becomes 60MB because of Architecture: any in scripts/release/debian/prepare.sh.

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2022-10-13T10:22:47Z

Really long-awaited feature to support ARM64, good job!

wangzelin007 · 2022-10-14T18:25:30Z

/azp run

azure-pipelines · 2022-10-14T18:25:45Z

Azure Pipelines successfully started running 2 pipeline(s).

bebound · 2022-10-20T04:00:43Z

scripts/release/rpm/ubi.dockerfile

    rpmbuild -v -bb --clean scripts/release/rpm/azure-cli.spec && \
-    cp /root/rpmbuild/RPMS/x86_64/azure-cli-${cli_version}-1.*.x86_64.rpm /azure-cli-dev.rpm
+    cp /root/rpmbuild/RPMS/**/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \
+    mkdir /out && cp /root/rpmbuild/RPMS/**/azure-cli-${cli_version}-1.*.rpm /out/


docker cp does not support wildcard, move target package to out folder.

bebound · 2022-10-20T04:02:38Z

scripts/release/debian/prepare.sh

 Package: azure-cli
-Architecture: all
+Architecture: any
 Depends: \${shlibs:Depends}, \${misc:Depends}


This also change deb package name from all.deb to amd64.deb

The package size also decrease by 20MB.

Specifying only any indicates that the source package isn’t dependent on any particular architecture and should compile fine on any one. The produced binary package(s) will be specific to whatever the current build architecture is.

Specifying only all indicates that the source package will only build architecture-independent packages.
https://www.debian.org/doc/debian-policy/ch-controlfields.html

jiasli · 2023-02-13T07:18:34Z

scripts/ci/install_docker.sh

+    exit 0
+fi
+# https://docs.docker.com/engine/security/rootless/
+/bin/bash -c "$(curl -fsSL https://get.docker.com)"


I strongly feel we should persuade 1ES to provide an image with docker, instead of installing docker by ourselves.

Hope this issue will be fixed one day. actions/runner-images#5631

jiasli · 2023-02-13T07:22:44Z

scripts/release/debian/deb_install.sh

        fi
    fi
-    echo "deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ ${CLI_REPO} main" \
+    echo "deb [arch=$(dpkg --print-architecture)] https://packages.microsoft.com/repos/azure-cli/ ${CLI_REPO} main" \


Nice catch. This may solve #25393.

jiasli · 2023-02-13T07:25:10Z

scripts/release/debian/prepare.sh

 ${TAB}mkdir -p debian/azure-cli/etc/bash_completion.d/
 ${TAB}cat ${completion_script} > debian/azure-cli/etc/bash_completion.d/azure-cli
-${TAB}dpkg-shlibdeps -v --warnings=7 -Tdebian/azure-cli.substvars -dDepends -edebian/azure-cli/opt/az/bin/python3 debian/azure-cli/opt/az/lib/python3.10/lib-dynload/_ssl.cpython-310-x86_64-linux-gnu.so
+${TAB}ssl_file=$(find debian/azure-cli/opt/az/lib/python3.10/ -type f -name '_ssl.cpython-310-*-linux-gnu.so')


Perhaps we don't need to use find, similar to #24180 (comment).

Yes indeed!

jiasli · 2023-02-13T07:31:47Z

scripts/release/rpm/mariner.dockerfile

    rpmbuild -v -bb --clean scripts/release/rpm/azure-cli.spec && \
-    cp /usr/src/mariner/RPMS/x86_64/azure-cli-${cli_version}-1.cm2.x86_64.rpm /azure-cli-dev.rpm
+    cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \
+    mkdir /out && cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /out/


Any reason for copying to /out?

In scripts/release/rpm/pipeline.sh, we'll copy the rpm file with docker cp $id:/out/. ${BUILD_STAGINGDIRECTORY} later.
RPMs are in different folders on amd64 and arm64, but docker cp does not support wildcard. I move target package to out folder.

TravisEz13 · 2023-02-27T23:48:39Z

Any timeline for this to be released?

bebound · 2023-02-28T02:09:40Z

@TravisEz13 On March 07

ghost requested review from jiasli, kairu-ms, wangzelin007 and yonzhan October 13, 2022 07:43

ghost added the Auto-Assign Auto assign by bot label Oct 13, 2022

ghost assigned jiasli Oct 13, 2022

ghost added this to the Oct 2022 (2022-11-01) milestone Oct 13, 2022

ghost added the Packaging label Oct 13, 2022

bebound force-pushed the arm64 branch from 301635a to 490735d Compare October 13, 2022 07:54

bebound force-pushed the arm64 branch from 490735d to 1263b3d Compare October 14, 2022 05:59

Azure deleted a comment from azure-pipelines bot Oct 14, 2022

wangzelin007 closed this Oct 15, 2022

wangzelin007 reopened this Oct 15, 2022

bebound added 4 commits October 18, 2022 10:03

Support RPM

1356ec7

Support DEB

0dccf4f

Merge yml

cd91cde

Use variables

80eedec

bebound force-pushed the arm64 branch from 1263b3d to 80eedec Compare October 18, 2022 02:10

bebound added 4 commits October 18, 2022 12:13

Fix artifact name

dc4a186

Add DEB_NAME

d9cf405

Minor fix

5eed879

Fix architecture

4294fd5

bebound marked this pull request as ready for review October 19, 2022 06:15

bebound requested a review from calvinhzy as a code owner October 19, 2022 06:15

bebound commented Oct 20, 2022

View reviewed changes

yonzhan removed this from the Oct 2022 (2022-11-01) milestone Oct 26, 2022

bebound requested a review from jiasli February 10, 2023 07:16

andrew-benson mentioned this pull request Feb 10, 2023

Release for aarch64 Azure/azure-functions-core-tools#3112

Closed

jiasli reviewed Feb 13, 2023

View reviewed changes

Minor fix

92b4d74

bebound requested review from DaeunYim, andyliuliming, digimaun, evelyn-ys, jsntcy, necusjz, yanzhudd and zhoxing-ms as code owners February 14, 2023 02:26

Merge remote-tracking branch 'upstream/dev' into arm64

322091f

bebound force-pushed the arm64 branch from 28a951b to 322091f Compare February 14, 2023 02:28

jiasli approved these changes Feb 14, 2023

View reviewed changes

bebound merged commit e0883f1 into Azure:dev Feb 14, 2023

This was referenced Feb 14, 2023

cannot execute binary file: Exec format error #16822

Closed

Arm64 package is available MicrosoftDocs/azure-docs-cli#3522

Merged

bebound added a commit to bebound/azure-cli that referenced this pull request Feb 14, 2023

[Packaging] Support ARM64 on Linux (Azure#24180)

bbc4d2f

bebound mentioned this pull request Mar 1, 2023

add support for arm64 Helm binaries. Azure/azure-cli-extensions#5173

Open

3 tasks

bebound deleted the arm64 branch March 20, 2023 06:51

avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023

[Packaging] Support ARM64 on Linux (Azure#24180)

049447c

bebound mentioned this pull request Sep 11, 2023

Installation script needs to be fixed for ARM64 #24117

Closed

jiasli mentioned this pull request May 13, 2024

[Packaging] Drop Ubuntu 18.04 support #28942

Merged

bebound mentioned this pull request Apr 11, 2025

Cannot install azure-cli on Ubuntu Noble - E: Unable to locate package azure-cli #28971

Closed

Conversation

bebound commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wangzelin007 commented Oct 14, 2022

Uh oh!

azure-pipelines bot commented Oct 14, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bebound Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiasli Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Feb 27, 2023

Uh oh!

bebound commented Feb 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bebound commented Oct 13, 2022 •

edited

Loading

yonzhan commented Oct 13, 2022 •

edited

Loading

bebound Feb 13, 2023 •

edited

Loading

jiasli Feb 13, 2023 •

edited

Loading