{Core} Log allow_broker configuration in telemetry#24304
Merged
{Core} Log allow_broker configuration in telemetry#24304
allow_broker configuration in telemetry#24304Conversation
allow_broker configuration in telemetry
Collaborator
|
telemetry for WAM feature |
jiasli
reviewed
Oct 24, 2022
Member
|
Really descriptive PR description. |
jiasli
approved these changes
Oct 24, 2022
This was referenced Jul 24, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
* Log allow_broker configuration in telemetry * rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #23956
This PR adds
allow_brokerconfiguration in telemetry when it's loaded and used for callingmsalTesting Guide
Scenario 1: Test telemetry logging when no
allow_brokeris configuredRun commands:
az loginaz group show -g {resource_group_name}Open
$home_dir/.azure/telemetry/cachefile and check the record data, you will find"Context.Default.AzureCLI.AllowBroker": "None"for both commandsScenario 2: Test telemetry logging when
allow_brokeris configured astrueConfig with
az config set core.allow_broker=trueRun commands:
az versionaz loginaz group show -g {resource_group_name}Open
$home_dir/.azure/telemetry/cachefile and check the record data, you will find"Context.Default.AzureCLI.AllowBroker": "None"for the first command, asaz versiondoesn't need auth, no msal call stack"Context.Default.AzureCLI.AllowBroker": "True"for the other two commands, this configuration is used for calling msal authScenario 3: Test telemetry logging when
allow_brokeris configured asfalseConfig with
az config set core.allow_broker=falseRun commands:
az versionaz loginaz group show -g {resource_group_name}Open
$home_dir/.azure/telemetry/cachefile and check the record data, you will find"Context.Default.AzureCLI.AllowBroker": "None"for the first command, asaz versiondoesn't need auth, no msal call stack"Context.Default.AzureCLI.AllowBroker": "False"for the other two commands, this configuration is used for calling msal authThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.