{Core} Add msal_telemetry to client telemetry#26980
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
ghost
added
the
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
jiasli
commented
Jul 24, 2023
evelyn-ys
reviewed
Jul 25, 2023
rayluo
previously approved these changes
Jul 26, 2023
evelyn-ys
previously approved these changes
Jul 26, 2023
jiasli
commented
Jul 26, 2023
Comment on lines
+466
to
+467
| if not _session.msal_telemetry: | ||
| _session.msal_telemetry = msal_telemetry |
Member
Author
There was a problem hiding this comment.
If a CLI command makes several MSAL calls, only the first telemetry record is preserved.
The most special command is az login which calls acquire_token_interactive first, then several subsequent acquire_token_silent_with_errors:
acquire_token_interactive: initial loginacquire_token_silent_with_error: list tenantsacquire_token_silent_with_error: list subscriptions in tenant 1acquire_token_silent_with_error: list subscriptions in tenant 2- ...
If step 1 fails, its telemetry will be sent and az login will fail. If step 1 succeeds, its telemetry will be sent, and step 2 and following steps' telemetry will be discarded, no matter if they fail or not.
For long running operation commands such as az storage account create, only the MSAL telemetry for the initial PUT request is sent. Following MSAL telemetry for GET polling requests is discarded.
jiasli
requested review from
calvinhzy,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
evelyn-ys
approved these changes
Jul 26, 2023
3 tasks
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Incorporate AzureAD/microsoft-authentication-library-for-python#575 and add
msal_telemetryfrom MSAL's response to Azure CLI's client telemetry. (Similar to howcore.allow_brokerconfiguration is added to client telemetry: #24304)Testing Guide
Then