[ServiceBus] Fix #24741: Remove invalid arguments for entity update commands#24801
Closed
PramodValavala-MSFT wants to merge 1 commit intoAzure:devfrom
PramodValavala-MSFT:prvalav/servicebus-invalid-arguments
Closed
[ServiceBus] Fix #24741: Remove invalid arguments for entity update commands#24801PramodValavala-MSFT wants to merge 1 commit intoAzure:devfrom PramodValavala-MSFT:prvalav/servicebus-invalid-arguments
PramodValavala-MSFT wants to merge 1 commit intoAzure:devfrom
PramodValavala-MSFT:prvalav/servicebus-invalid-arguments
Conversation
Collaborator
|
ServiceBus |
Member
|
Hi @PramodValavala-MSFT , thanks for working on this. There might need to be testcase updates that need to be made to this, I can take this from here if you invite me as a collaborator on your azure-cli fork. |
Contributor
Author
|
@damodaravadhani Sure. I've added you as a contributor to my fork. Let me know what tests you have in mind and I could help out too, if needed. |
Member
|
Hi @PramodValavala-MSFT , this is breaking change and we only allow breaking change twice a year. Can you add deprecation and warnings for now and totally remove them in next breaking change window? |
Member
|
Oh I've already seen #24937 adding the deprecation warning. I'll close this PR then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az servicebus queue update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection --enable-session az servicebus topic update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection az servicebus topic subscription update --resource-group {} --namespace-name {} --name {} --enable-sessionDescription
The following properties of an entity cannot be updated post creation but the update the commands for entities have these arguments, which are invalid and fail as such
This PR removes the arguments for the update commands.
resolves #24741
Testing Guide
az servicebus queue update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection --enable-session az servicebus topic update --resource-group {} --namespace-name {} --name {} --enable-partitioning --enable-duplicate-detection az servicebus topic subscription update --resource-group {} --namespace-name {} --name {} --enable-sessionThe above commands currently fail with a 400 Bad Request, which is expected due to the invalid arguments that can't be updated post entity creation. With this PR, they should be removed from the documentation, command help, and error as invalid arguments directly.
History Notes
[ServiceBus]
az servicebus queue update: Remove invalid arguments for queue update command[ServiceBus]
az servicebus topic update: Remove invalid arguments for topic update command[ServiceBus]
az servicebus topic subscription update: Remove invalid arguments for subscription update commandThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.