Conversation
ghost
added
ghost
requested review from
Collaborator
|
ServiceBus |
damodaravadhani
changed the title
az servicebus queue update: Adding breaking change alert messagesaz servicebus queue update: Add breaking change alert messages
Member
Author
|
@evelyn-ys, we are removing certain properties from |
evelyn-ys
approved these changes
Dec 21, 2022
3 tasks
zhoxing-ms
approved these changes
Dec 29, 2022
3 tasks
jiasli
reviewed
Feb 3, 2023
| from isodate import Duration | ||
| from azure.cli.core.azclierror import InvalidArgumentValueError | ||
| from azure.cli.command_modules.servicebus.constants import DURATION_SECS, DURATION_MIN, DURATION_DAYS | ||
| from argcomplete import warn |
Member
There was a problem hiding this comment.
Why using warn from argcomplete. This usage is weird.
jiasli
reviewed
Feb 3, 2023
| from datetime import timedelta | ||
| from isodate import parse_duration | ||
| from knack.util import CLIError | ||
| import warnings |
Member
There was a problem hiding this comment.
It is not Azure CLI convention to use warnings module. Instead, warnings in Azure CLI is written like
azure-cli/src/azure-cli/azure/cli/command_modules/profile/custom.py
Lines 38 to 39 in d331edf
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az servicebus queue update
Description
Adding breaking change alert messages wherever required
Testing Guide
History Notes
{ServiceBus}
az servicebus queue update: Add breaking change alertsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.