{Core} Bump MSAL to 1.27.0 and pin pymsalruntime to 0.14.0
#28556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
microsoft-github-policy-service
bot
added
Account
jiasli
commented
Mar 13, 2024
| pycparser==2.19 | ||
| PyGithub==1.55 | ||
| PyJWT==2.4.0 | ||
| pymsalruntime==0.14.0 |
Member
Author
There was a problem hiding this comment.
MSAL 1.26.0 requires
pymsalruntime>=0.13.2,<0.14; python_version>='3.6' and platform_system=='Windows'
So the latest allowed pymsalruntime is 0.13.12.
MSAL 1.27.0 requires
pymsalruntime>=0.13.2,<0.15; python_version>='3.6' and platform_system=='Windows'
If pymsalruntime 0.13.12 is already installed, azdev setup -c won't upgrade it to 0.14.0, so pymsalruntime is explicitly bumped and pinned to 0.14.0.
Meanwhile, as Azure CLI doesn't directly depend on pymsalruntime, pymsalruntime is not pinned in setup.py and any version allowed by MSAL is acceptable.
evelyn-ys
approved these changes
Mar 14, 2024
bebound
approved these changes
Mar 14, 2024
This was referenced Apr 11, 2024
This was referenced Jul 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
MSAL 1.27.0 (AzureAD/microsoft-authentication-library-for-python#669) contains several improvements.
The most significant one is to tolerate ID token time errors (AzureAD/microsoft-authentication-library-for-python#657) which will solve 2 very common issues:
az login: RuntimeError: 0. The ID token is not yet valid. #20388)az loginfails: RuntimeError: 9. The ID token already expires. #23223)pymsalruntime0.14.0 started to support Python 3.12: https://pypi.org/project/pymsalruntime/0.14.0/#files