{Core} Bump MSAL to 1.30.0 #29314
Merged
{Core} Bump MSAL to 1.30.0 #29314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
microsoft-github-policy-service
bot
added
Auto-Assign
yonzhan
previously approved these changes
Jul 4, 2024
jiasli
requested review from
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
bebound
approved these changes
Jul 17, 2024
evelyn-ys
approved these changes
Jul 17, 2024
rayluo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sshDescription
Fix #29006
MSAL 1.26.0 in Azure CLI 2.58.0 bypasses token cache for SSH cert which is the expected behavior:
But MSAL 1.27.0 (bumped by #28556) in Azure CLI 2.59.0 fetches SSH cert from token cache:
This caused issue #29006. MSAL 1.30.0 fixed the token cache in AzureAD/microsoft-authentication-library-for-python#717, so we should bump MSAL to 1.30.0 to adopt that fix.
See email: AADLogin failures with recent MSAL.py
History Notes
[Compute] Fix #29006:
az ssh: Fix thePermissions 0644 for '...' are too openerror