Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
bebound
force-pushed
the
lts-skip-version-check
branch
from
42fa5ca to
851ebc8
Compare
bebound
force-pushed
the
lts-skip-version-check
branch
from
851ebc8 to
e055a78
Compare
Member
|
header -> history |
bebound
commented
Feb 27, 2025
| - job: CheckHeaders | ||
| displayName: "Check License, History, and DocMap" | ||
|
|
||
| condition: and(not(contains(variables['Build.SourceBranch'], 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts'))) |
Contributor
Author
There was a problem hiding this comment.
In LTS PR:
Expanded: and(not(contains('refs/pull/30848/merge', 'lts')), not(contains('dev-lts-2.66', 'lts')))
In batched CI, System.PullRequest.TargetBranch is an empty string, and the condition is still correct.
Evaluating: and(not(contains(variables['Build.SourceBranch'], 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts')))
Expanded: and(not(contains('refs/heads/lts-skip-version-check', 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts')))
Member
There was a problem hiding this comment.
We don't need to consider Build.SourceBranch being refs/pull/30848/merge (PR) and System.PullRequest.TargetBranch being '' (batched CI) at all.
For PR, as contains('dev-lts-2.66', 'lts') is true, the and() fails. For batched CI, as contains('refs/heads/lts-skip-version-check', 'lts') is true, and() fails.
Maybe using or() makes the logic easier to understand:
not(or(contains(variables['Build.SourceBranch'], 'lts'), contains(variables['System.PullRequest.TargetBranch'], 'lts')))
Contributor
Author
There was a problem hiding this comment.
System.PullRequest.TargetBranch being '' is evaluated in dev branch batched CI.
not(contains('refs/heads/dev', 'lts') is true, and it will check not(contains('', 'lts').
jiasli
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like #30848, we don't have changelog for LTS and this check should be skipped.