Skip to content

{CI} Skip history check in LTS #30853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 1 commit into from
Mar 5, 2025
Merged

{CI} Skip history check in LTS #30853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ jobs:

- job: CheckHeaders
displayName: "Check License, History, and DocMap"

condition: and(not(contains(variables['Build.SourceBranch'], 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts')))
Copy link
Contributor Author

@bebound bebound Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In LTS PR:
Expanded: and(not(contains('refs/pull/30848/merge', 'lts')), not(contains('dev-lts-2.66', 'lts')))

In batched CI, System.PullRequest.TargetBranch is an empty string, and the condition is still correct.

Evaluating: and(not(contains(variables['Build.SourceBranch'], 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts')))
Expanded: and(not(contains('refs/heads/lts-skip-version-check', 'lts')), not(contains(variables['System.PullRequest.TargetBranch'], 'lts')))

Copy link
Member

@jiasli jiasli Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to consider Build.SourceBranch being refs/pull/30848/merge (PR) and System.PullRequest.TargetBranch being '' (batched CI) at all.

For PR, as contains('dev-lts-2.66', 'lts') is true, the and() fails. For batched CI, as contains('refs/heads/lts-skip-version-check', 'lts') is true, and() fails.

Maybe using or() makes the logic easier to understand:

not(or(contains(variables['Build.SourceBranch'], 'lts'), contains(variables['System.PullRequest.TargetBranch'], 'lts')))

Copy link
Contributor Author

@bebound bebound Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.PullRequest.TargetBranch being '' is evaluated in dev branch batched CI.
not(contains('refs/heads/dev', 'lts') is true, and it will check not(contains('', 'lts').

pool:
name: ${{ variables.ubuntu_pool }}
steps:
Expand Down