{LTS} Do not add post suffix for branches starting with release#30905
Merged
jiasli merged 1 commit intoAzure:dev-lts-2.66from Mar 3, 2025
Merged
{LTS} Do not add post suffix for branches starting with release#30905jiasli merged 1 commit intoAzure:dev-lts-2.66from
post suffix for branches starting with release#30905jiasli merged 1 commit intoAzure:dev-lts-2.66from
Conversation
|
Hi @jiasli, |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
jiasli
commented
Feb 27, 2025
| script_dir=`cd $(dirname $BASH_SOURCE[0]); pwd` | ||
|
|
||
| if [[ "$branch" != "release" ]]; then | ||
| if [[ ! $branch =~ ^release ]]; then |
Member
Author
There was a problem hiding this comment.
To test this regex match:
branch=dev
if [[ ! $branch =~ ^release ]]; then
echo not a release branch
fi
# output: not a release branch
branch=myfeature
if [[ ! $branch =~ ^release ]]; then
echo not a release branch
fi
# output: not a release branch
branch=release
if [[ ! $branch =~ ^release ]]; then
echo not a release branch
fi
branch=release-lts-2.66
if [[ ! $branch =~ ^release ]]; then
echo not a release branch
fi
jiasli
commented
Feb 27, 2025
| script_dir=`cd $(dirname $BASH_SOURCE[0]); pwd` | ||
|
|
||
| if [[ "$branch" != "release" ]]; then | ||
| if [[ ! $branch =~ ^release ]]; then |
Member
Author
There was a problem hiding this comment.
Double quotes in "$branch" are not necessary. The official Bash doc doesn't quote the first operand:
https://www.gnu.org/software/bash/manual/bash.html#index-_005b_005b
[[ $line =~ ^"initial string" ]]This is also confirmed by https://unix.stackexchange.com/questions/500828/why-use-double-quotes-in-a-test
From the output of set -x, we can see there is no difference:
set -x
branch="with a space"
if [[ $branch =~ ^release ]]; then
echo matched
fi
# output: + [[ with a space =~ ^release ]]
if [[ "$branch" =~ ^release ]]; then
echo matched
fi
# output: + [[ with a space =~ ^release ]]
jiasli
requested review from
bebound,
calvinhzy,
kairu-ms and
wangzelin007
as code owners
Collaborator
|
LTS |
bebound
approved these changes
Feb 28, 2025
jiasli
added a commit
to jiasli/azure-cli
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
pypibuild artifact of ec3172d contains thepostsuffix:These packages are incorrectly published to PyPI: https://pypi.org/project/azure-cli/2.66.1.post20250227030620/#files
We should not add
postsuffix for branches starting withreleaseincludingrelease-lts-2.66.Testing Guide
Create a new branch
release-lts-2.66-testand trigger the release pipeline. Make sure the artifacts does not containpostsuffix.