Skip to content

{LTS} Do not add post suffix for branches starting with release #30905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Mar 3, 2025
Merged

{LTS} Do not add post suffix for branches starting with release #30905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/release/pypi/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pip list

script_dir=`cd $(dirname $BASH_SOURCE[0]); pwd`

if [[ "$branch" != "release" ]]; then
if [[ ! $branch =~ ^release ]]; then
Copy link
Member Author

@jiasli jiasli Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this regex match:

branch=dev
if [[ ! $branch =~ ^release ]]; then
    echo not a release branch
fi
# output: not a release branch

branch=myfeature
if [[ ! $branch =~ ^release ]]; then
    echo not a release branch
fi
# output: not a release branch

branch=release
if [[ ! $branch =~ ^release ]]; then
    echo not a release branch
fi

branch=release-lts-2.66
if [[ ! $branch =~ ^release ]]; then
    echo not a release branch
fi

Copy link
Member Author

@jiasli jiasli Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double quotes in "$branch" are not necessary. The official Bash doc doesn't quote the first operand:

https://www.gnu.org/software/bash/manual/bash.html#index-_005b_005b

[[ $line =~ ^"initial string" ]]

This is also confirmed by https://unix.stackexchange.com/questions/500828/why-use-double-quotes-in-a-test

From the output of set -x, we can see there is no difference:

set -x
branch="with a space"

if [[ $branch =~ ^release ]]; then
    echo matched
fi
# output: + [[ with a space =~ ^release ]]

if [[ "$branch" =~ ^release ]]; then
    echo matched
fi
# output: + [[ with a space =~ ^release ]]

. $script_dir/../../ci/version.sh post`date -u '+%Y%m%d%H%M%S'`
fi

Expand Down
Loading