Increase module perf. threshold for SQL#6218
Merged
tjprescott merged 1 commit intoAzure:devfrom Apr 25, 2018
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6218 |
Member
Author
tjprescott
suggested changes
Apr 25, 2018
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
When I run the script locally, I keep seeing one thing fail--sometimes it is SQL, sometimes servicebus. Detecting these regressions is the purpose of this script, so I don't think just raising the threshold makes sense.
troydai
approved these changes
Apr 25, 2018
tjprescott
approved these changes
Apr 25, 2018
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks us in CI.
Haven't done a root cause analysis to understand why the load time in Travis CI has gone up for this module but locally, it seems fine and looking at the code, nothing has changed in this module over the last day.