Update Homebrew Formula to install in Virtualenv#8744
Merged
Conversation
Member
Author
|
There is a known issue I'm still working around, where for some reason two versions of wheel are installed simultaneously after the installer finishes. However, I thought I'd get this open now to allow review/commenting on what I do have at the moment. |
This brings us into conformance with the guidelines for how to install Python applications in Homebrew: https://github.com/Homebrew/brew/blob/5eaf4e5c28e7605cd9d8e1631d376b0e46c98624/docs/Python-for-Formula-Authors.md#installing However, it is worth noting that after some internal discussions, it seems that there may be more clever ways to achieve the same levels of isolation. This change is not a philosophic disagreement with those ideas, just a pragmatic way forward until a better way is obvious.
This is a workaround for pypa/pip#6222. It should not be a permanent change.
This allows us to remove our dependency on an older version of the 'wheel' package. Rob Pike has a saying, "A little copy is better than a little dependency". I believe it's very applicable here, and you can here him talk about that philosophy here: https://www.youtube.com/watch?v=PAAkCSZUG1c&t=9m28s
marstr
commented
Mar 11, 2019
williexu
approved these changes
Mar 11, 2019
Contributor
williexu
left a comment
williexu
left a comment
There was a problem hiding this comment.
Tested the homebrew install from source code personally with no problems.
This reverts commit 498a066.
yugangw-msft
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8689