[Test] Traffic is not recorded by default during RGPreparer setup.#9431
[Test] Traffic is not recorded by default during RGPreparer setup.#9431
Conversation
tjprescott
left a comment
There was a problem hiding this comment.
I feel this solution should be more generic since NONE of the preparers should record traffic, not just resource group. However, if the cost-benefit analysis does justify the extra work, this should be fine.
There was a problem hiding this comment.
The intent with preparers is that none of the traffic for their creation is recorded. They are "assumed to exist" on playback. Thus, this fix should really be implemented in some kind of base class, because it should equally apply to StorageAccountPreparers and all the others.
There was a problem hiding this comment.
Sure, this makes sense. The other preparers might be complicated as they sometimes rely on nondeterministic info (at least StorageAccountPreparers), but it is definitely doable.
I will make the changes.
8aa2209 to
d2a962c
Compare
|
I think this should be good to go @tjprescott @yugangw-msft Is there any need for updated documentation? Also, it would be best to merge this after the release. |
c1a8700 to
72b57cf
Compare
…eate_service_no_wait.
…to str() in python 2 in replacers. Re-record profile tests.
…nd 2 on test_graph_app_cred_e2e.
2bcd303 to
cde9c82
Compare
… scope. This was cause of test_security_tasks flakiness.
Resource Group Preparer is no longer recorded. Moreover
group createandgroup deletelogic will be ignored if the test is not run live.This can be extended to other preparers as well. It might be a bit more complicated if the preparer returns information that isn't an input. E.g.
account_keyin the case of theStorageAccountPreparer. But it is doable. In the case of the StorageAccountPreparer, we can solve this problem by returning the recording replacement of the account key.closes #9272
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.