This repository was archived by the owner on Oct 12, 2023. It is now read-only.
Merged
Conversation
…its type is byte.
Contributor
Author
|
I don't think this approach is cross platform though, as str(encoding='utf-8') was added in python 3 |
adewaleo
commented
Jun 4, 2019
|
|
||
| if is_text_payload(request) and request.body: | ||
| body = str(request.body) | ||
| body = str(request.body, 'utf-8') if isinstance(request.body, bytes) else str(request.body) |
Contributor
Author
There was a problem hiding this comment.
bytes is an alias for str from python 2.6 onwards in python 2, so this won't NameError
lmazuel
approved these changes
Jun 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SingleValueReplacer.process_request properly decodes request.body if its type is byte.
Current implementation of process_request plays poorly with vcr.request.body setter as it encodes strings back to bytes.
The following assumes python 3.
cc: @lmazuel
See this line in Azure/azure-cli#9431