Skip to content

Comments

Add empty javadoc and sources jar for spring starters#28988

Merged
saragluna merged 2 commits intoAzure:mainfrom
saragluna:xiada/fix-empty-javadoc-and-source
May 21, 2022
Merged

Add empty javadoc and sources jar for spring starters#28988
saragluna merged 2 commits intoAzure:mainfrom
saragluna:xiada/fix-empty-javadoc-and-source

Conversation

@saragluna
Copy link
Member

Description

#28967 enabled verification for build artifacts required by maven to publish in ci pipelines, which means the Spring ci will fail because the starters having no javadoc and sources jar. This PR will try to add these two jar files for starters.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label May 20, 2022
@saragluna saragluna added this to the [2022] June milestone May 20, 2022
Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saragluna I'm fine with the change however, I would like the <!-- START: Empty Java Doc --> and <!-- END: Empty Java Doc --> tags at the beginning and ends of the block like all of the other files have in them.

@saragluna saragluna merged commit a44a6d3 into Azure:main May 21, 2022
@saragluna saragluna deleted the xiada/fix-empty-javadoc-and-source branch May 21, 2022 02:20
@saragluna saragluna self-assigned this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants