Stop using a parameter for Artifacts in spring/ci.yml#28989
Merged
saragluna merged 2 commits intoAzure:mainfrom May 21, 2022
Merged
Stop using a parameter for Artifacts in spring/ci.yml#28989saragluna merged 2 commits intoAzure:mainfrom
saragluna merged 2 commits intoAzure:mainfrom
Conversation
Member
Author
|
The broken ci will be fixed in #28988. |
JimSuplizio
approved these changes
May 20, 2022
Contributor
JimSuplizio
left a comment
There was a problem hiding this comment.
This looks good @saragluna, thank you for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The spring/ci.yml passed the Artifacts as a parameter to spring-sdk-client-test.yml to run compatibility tests. But since we have switched to a new compatibility-test pipeline, #28982, there's no need to keep the artifacts as a parameter. This PR is to remove the parameter.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines