Skip to content

Comments

Stop using a parameter for Artifacts in spring/ci.yml#28989

Merged
saragluna merged 2 commits intoAzure:mainfrom
saragluna:xiada/fix-spring-ci-paramters
May 21, 2022
Merged

Stop using a parameter for Artifacts in spring/ci.yml#28989
saragluna merged 2 commits intoAzure:mainfrom
saragluna:xiada/fix-spring-ci-paramters

Conversation

@saragluna
Copy link
Member

Description

The spring/ci.yml passed the Artifacts as a parameter to spring-sdk-client-test.yml to run compatibility tests. But since we have switched to a new compatibility-test pipeline, #28982, there's no need to keep the artifacts as a parameter. This PR is to remove the parameter.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@saragluna saragluna requested a review from hallipr as a code owner May 20, 2022 10:52
@ghost ghost added the azure-spring All azure-spring related issues label May 20, 2022
@saragluna
Copy link
Member Author

The broken ci will be fixed in #28988.

@JimSuplizio JimSuplizio self-requested a review May 20, 2022 17:52
Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @saragluna, thank you for doing this.

@saragluna saragluna merged commit 30e0ef0 into Azure:main May 21, 2022
@saragluna saragluna deleted the xiada/fix-spring-ci-paramters branch May 21, 2022 02:43
@saragluna saragluna self-assigned this May 23, 2022
@saragluna saragluna added this to the [2022] June milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants