Add skipPublishDocGithubIo for all Spring starters#29009
Add skipPublishDocGithubIo for all Spring starters#29009saragluna merged 2 commits intoAzure:mainfrom
Conversation
|
Hi @saragluna, when will this PR be merged? I'm getting ci error here: Thought this PR would fix this? |
|
Hi @XiaofeiCao, I checked the pipeline and it's because we are using a README file in |
|
Hi @XiaofeiCao, I just created this #29013 to fix the issue. |
Thanks! |
JimSuplizio
left a comment
There was a problem hiding this comment.
Thank you @saragluna. This makes the doc publishing (or lack thereof) consistent.
@saragluna the problem here is that every library, in theory, is supposed to have a README and that's what should be included in the empty javadoc/sources, not the root README. Spring seems to be an exception to this. I'm looking at changing the sparse checkout paths generated for the FromSource runs to accommodate this but that probably won't be fixed until tomorrow (Tuesday, May 24th). |
|
@JimSuplizio, we are trying to see whether we could skip the README.md files in Spring empty Javadoc or sources jar files in #29014. The jar files will contain a |
@saragluna there's a reason we're putting the README into the 'empty' sources and javadocs and that's because of explicit instructions for publishing. |
Description
The Spring starters have no Javadocs, so we should stop publishing the empty Javadoc jars to the GitHub IO site. This PR will add the
skipPublishDocGithubIo: trueto all Spring starters.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines