Delete README.md in java-doc-jar and source-jar.#29014
Closed
chenrujun wants to merge 2 commits intoAzure:mainfrom
Closed
Delete README.md in java-doc-jar and source-jar.#29014chenrujun wants to merge 2 commits intoAzure:mainfrom
chenrujun wants to merge 2 commits intoAzure:mainfrom
Conversation
chenrujun
requested review from
Netyyyy,
backwind1233,
hui1110,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
the
Author
|
/azp run java - resourcemanager - ci |
|
Comment was made before the most recent commit for PR 29014 in repo Azure/azure-sdk-for-java |
Collaborator
|
API change check API changes are not detected in this pull request. |
saragluna
reviewed
May 23, 2022
2. Remove unnecessary configuration: "<classesDirectory>". 3. Remove "-with-readme" in execution id.
Author
|
/azp run java - resourcemanager - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
6 tasks
Author
|
Hi, @saragluna , please help to review this PR when you have time. |
Member
|
According to @JimSuplizio's reply #29009 (comment), I think we should wait for the fix for sparse checkout. |
Author
|
Closing this PR, because README.md is necessary. Refs: #29009 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue to #29013, delete README.md in java-doc-jar and source-jar.
failonerror="false"is not a good practice.README.mdis forSpring Cloud Azure, not for specific starter. So, it's not good to put it in starter's jar file.