[Automation] Generate SDK based on TypeSpec 0.20.0 DEV#41600
Closed
azure-sdk wants to merge 1 commit intoAzure:mainfrom
Closed
[Automation] Generate SDK based on TypeSpec 0.20.0 DEV#41600azure-sdk wants to merge 1 commit intoAzure:mainfrom
azure-sdk wants to merge 1 commit intoAzure:mainfrom
Conversation
Collaborator
Author
|
API change check API changes are not detected in this pull request. |
| @@ -25587,7 +25610,7 @@ public Mono<Response<Void>> rebootNodeInternalWithResponseAsync(String poolId, S | |||
| } | |||
| }); | |||
| return FluxUtil.withContext(context -> service.rebootNodeInternal(this.getEndpoint(), | |||
| this.getServiceVersion().getVersion(), contentType, poolId, nodeId, accept, requestOptionsLocal, context)); | |||
| this.getServiceVersion().getVersion(), poolId, nodeId, accept, requestOptionsLocal, context)); | |||
Member
There was a problem hiding this comment.
mark, the default setted content-type is removed. And it should be passed from client method.
Member
|
You can ignore the diff in healthinsights, as this lib is not synced before (we are waiting for their GA PR). However, the api-version should not changed? (as the commit ID stays same) |
| Boolean returnFaceLandmarks = options.isReturnFaceLandmarks(); | ||
| Boolean returnRecognitionModel = options.isReturnRecognitionModel(); | ||
| Integer faceIdTimeToLive = options.getFaceIdTimeToLive(); | ||
| DetectFromUrlImplRequest detectFromUrlRequestObj = new DetectFromUrlImplRequest(options.getUrl()); |
Member
There was a problem hiding this comment.
parameter setting order changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Automation] Generate SDK based on TypeSpec 0.20.0 DEV
Diffs summary:
summary and descriptionin codegen. e.g.https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-22a86c1583ab90d90851139f385f25e4184e565365883b077d8fdfa47ea1e0d2R24971But in impl, the default setted content-type is removed. But in the impl it will add default content type here
https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-8f1796f453e43d1d28aa2b031053d2e21f6ce3eef5d4dd9929b5a125ce6d596cR25603
tsp: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/batch/Azure.Batch/routes.tsp#L1319
They explicitly specified content-type: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/batch/Azure.Batch/common.tsp#L131
tsp: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/Face/routes.detection.tsp,
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/Face/models.detect.tsp
acceptheader'sapplication/jsonvalue is removed. e.g. https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-2b69dc7105600fc163760d8b834bf171ed6880b198d30043f65026f68b931c59L372tsp: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communication/Communication.Messages/routes.tsp#L46
This is because previously we will add
response.body.contentTypestoacceptheader's content type value by ourselves, but now we use TCGC to getacceptheader's content type value.1 is expected, 2,3,4,5 I'm investigating the root cause.