Skip to content

Remove sampler arg env var logic once it is added to Sampler #32499

@jeremydvoss

Description

@jeremydvoss

Migrating from microsoft/ApplicationInsights-Python#264

See microsoft/ApplicationInsights-Python#262 for details

Currently, the Sampler object does not check the OTEL_TRACES_SAMPLER_ARG env var during initialization. Instead, the configuration layers above it -- configure_azure_monitor or autoinstrumentation -- check the env var and pass in a parsed value if appropriate. If we add this logic to the sampler object itself, we could remove it from the distro's configure_azure_monitor. However, we would need to keep that in the OTel-side autoinstrumentaiton logic no matter what. This change is mainly a design preference. However, if someone is using the piecemeal exporter approach, it would be a new configuration option.

Metadata

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.Monitor - ApplicationInsightsMonitor - DistroMonitor OpenTelemetry DistroOpenTelemetryOpenTelemetry instrumentation (not Monitor-specific)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions