Skip to content

Enable env var configuration, defaulting, validation#262

Merged
jeremydvoss merged 20 commits intomicrosoft:mainfrom
jeremydvoss:env-var
Mar 31, 2023
Merged

Enable env var configuration, defaulting, validation#262
jeremydvoss merged 20 commits intomicrosoft:mainfrom
jeremydvoss:env-var

Conversation

@jeremydvoss
Copy link
Copy Markdown
Member

@jeremydvoss jeremydvoss commented Mar 22, 2023

New todos:

@jeremydvoss jeremydvoss marked this pull request as ready for review March 22, 2023 22:57
@jeremydvoss jeremydvoss requested review from a team and lzchen as code owners March 22, 2023 22:57
@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 23, 2023

Could you add more details to the issues #263 #264 and #265?

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 23, 2023

Add env var logic to sampler https://github.com/microsoft/ApplicationInsights-Python/issues/263

How is changing the logging level related to the sampler?

@jeremydvoss
Copy link
Copy Markdown
Member Author

jeremydvoss commented Mar 24, 2023

Add env var logic to sampler https://github.com/microsoft/ApplicationInsights-Python/issues/263

How is changing the logging level related to the sampler?

Not log level --OTEL_TRACES_SAMPLER_ARG. Following the structure of the other otel components, I think the sampler itself should check the env var

EDIT: Oh, I see the confusion. I mismatched the issues with their descriptions in this PR. Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organize constants Add validation for configuration options Implement configuration through environment variables

2 participants