Configuration arguments validation#258
Closed
jeremydvoss wants to merge 3 commits intomicrosoft:mainfrom
Closed
Conversation
jeremydvoss
force-pushed
the
type-validation
branch
2 times, most recently
from
5702e89 to
85243fa
Compare
jeremydvoss
force-pushed
the
type-validation
branch
from
85243fa to
e0cd36e
Compare
lzchen
reviewed
Mar 20, 2023
| assert _is_instance_or_none( | ||
| configurations.get("exclude_instrumentations"), Sequence | ||
| ) | ||
| assert _is_instance_or_none(configurations.get("resource"), Resource) |
Contributor
There was a problem hiding this comment.
The idea of this PR is not really to do type checking (it would be too cumbersome to always check for typing, plus this is why we use typing.
We want to only have a few validation checks for logic (like interval needs to be > 0).
The idea for Python and for the distro is that if input is not the correct type, it will not do anything with that input.
lzchen
reviewed
Mar 20, 2023
| assert _is_instance_or_none(configurations.get("logging_level"), int) | ||
| assert _is_instance_or_none(configurations.get("logger_name"), str) | ||
| assert _is_instance_or_none( | ||
| configurations.get("logging_export_interval_millis"), int |
Contributor
There was a problem hiding this comment.
Non-negative values for intervals.
lzchen
reviewed
Mar 20, 2023
| ) | ||
| for library in _SUPPORTED_INSTRUMENTED_LIBRARIES: | ||
| assert _is_instance_or_none( | ||
| configurations.get(library + "_config"), Dict |
Contributor
There was a problem hiding this comment.
Might have to rebase this and validate instrumentation_config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing with #262 262