[form recognizer] Rename models property of CustomFormModel to submodels#11633
Merged
iscai-msft merged 5 commits intoAzure:masterfrom May 28, 2020
Merged
[form recognizer] Rename models property of CustomFormModel to submodels#11633iscai-msft merged 5 commits intoAzure:masterfrom
iscai-msft merged 5 commits intoAzure:masterfrom
Conversation
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: rename edm to SearchFieldDataType (Azure#11597) ignoring value of document status for multipage tests (Azure#11631)
iscai-msft
requested review from
annelo-msft,
jeremymeng,
kinelski,
kristapratico,
maririos,
mssfang,
rakshith91,
samvaity and
willmtemple
kristapratico
previously approved these changes
May 26, 2020
maririos
previously approved these changes
May 26, 2020
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] merging feature branch into master (Azure#11632) regen swagger and make list_indexes pageable (Azure#11635) Sync eng/common directory with azure-sdk-tools repository (Azure#11566) Rename to completed_on and requested_on in the CustomFormModel (Azure#11592) [formrecognizer] model_id param validation (Azure#11569) [Batch] Fix issue in latest REST API (Azure#11604)
kristapratico
previously approved these changes
May 27, 2020
maririos
reviewed
May 27, 2020
| :ivar ~datetime.datetime completed_on: | ||
| Date and time (UTC) when model training completed. | ||
| :ivar list[~azure.ai.formrecognizer.CustomFormSubModel] models: | ||
| :ivar list[~azure.ai.formrecognizer.CustomFormSubModel] submodels: |
Member
There was a problem hiding this comment.
if we are using submodel should we rename to CustomFormSubmodel?
Anne pointed that out in .NET PR => Azure/azure-sdk-for-net#12313 (comment)
Contributor
Author
There was a problem hiding this comment.
thanks, that makes sense! let me update the issues
rakshith91
previously approved these changes
May 27, 2020
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: Increment package version after release of azure_ai_textanalytics (Azure#11664) DefaultAzureCredential can configure InteractiveBrowserCredential's tenant (Azure#11662) use CIMultiDict when pickling (Azure#11661) [text analytics] update version to b6 (Azure#11660)
kristapratico
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11389