Quick fix for broken log analytics pipeline.#12464
Merged
mitchdenny merged 1 commit intorelease/v3from Jul 9, 2020
Merged
Conversation
mitchdenny
requested review from
danieljurek,
scbedd,
weshaggard and
zikalino
as code owners
praveenkuttappan
approved these changes
Jul 9, 2020
weshaggard
reviewed
Jul 9, 2020
| type: github | ||
| name: Azure/azure-sdk-tools | ||
| endpoint: azure | ||
| ref: 0aedb8f2c152440e22d49317ad417c7c1d10a67c |
Member
There was a problem hiding this comment.
We will need to fix all the ci.yml files in this branch if they plan to release others. @chidozieononiwu can you run your ref update on this branch to get it to update all the references with tags.
Member
There was a problem hiding this comment.
Running the ref updater at this point will not resolve this issue as the new tag created will already be ahead of the change that caused the break. Also I will have to adjust the tool to accommodate branches other than master and maybe allow passing of already existing tags that way it can used a specific tag prior to the recent changes that caused the break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@praveenkuttappan this is the ref trick I was talking about. I've just applied it to the loganalytics
ci.ymlfile. This should unblock the team and is very surgical, however we should probably go through and change all of the ci.yml files to pin them to the latest known good tagged version ofazure-sdk-tools. @chidozieononiwu has been doing some work in this space recently.