Skip to content

Quick fix for broken log analytics pipeline. #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 1 commit into from
Jul 9, 2020
Merged

Quick fix for broken log analytics pipeline. #12464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/loganalytics/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ resources:
type: github
name: Azure/azure-sdk-tools
endpoint: azure
ref: 0aedb8f2c152440e22d49317ad417c7c1d10a67c
Copy link
Member

@weshaggard weshaggard Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to fix all the ci.yml files in this branch if they plan to release others. @chidozieononiwu can you run your ref update on this branch to get it to update all the references with tags.

Copy link
Member

@weshaggard weshaggard Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12459 looks to be the better fix.

Copy link
Member

@chidozieononiwu chidozieononiwu Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the ref updater at this point will not resolve this issue as the new tag created will already be ahead of the change that caused the break. Also I will have to adjust the tool to accommodate branches other than master and maybe allow passing of already existing tags that way it can used a specific tag prior to the recent changes that caused the break.

- repository: azure-sdk-build-tools
type: git
name: internal/azure-sdk-build-tools
Expand Down