[ServiceBus] Change name to <entity>_name naming for remaining "name" parameters#14393
Merged
KieranBrantnerMagee merged 1 commit intoAzure:masterfrom Oct 14, 2020
Conversation
…n AdministrationClient to normalize with existing naming schemes.
KieranBrantnerMagee
added
Service Bus
Client
KieranBrantnerMagee
requested review from
YijunXieMS,
rakshith91 and
yunhaoling
KieranBrantnerMagee
requested review from
annatisch,
changlong-liu,
jsntcy and
msyyc
as code owners
Member
Author
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Oct 12, 2020
Contributor
yunhaoling
left a comment
yunhaoling
left a comment
There was a problem hiding this comment.
LGTM. changelog update is missing :P
Member
Author
|
re: changelog update, since this is all green and we're tight for time, I slipped that line here. Not my proudest moment but if you have no issues I'll slip this in. |
iscai-msft
added a commit
that referenced
this pull request
Oct 14, 2020
…into fr-selection-marks * 'master' of https://github.com/Azure/azure-sdk-for-python: [form recognizer] Add selection forms (#14511) Update Azure.Identity and KeyVault codeowners (#14470) Minimize packages installed for depends test (#13957) Change name to <entity>_name naming for remaining "name" parameters in AdministrationClient to normalize with existing naming schemes. (#14393)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For AdministrationClient to normalize with existing naming schemes.