Skip to content

[ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender)#14502

Merged
KieranBrantnerMagee merged 13 commits intoAzure:masterfrom
KieranBrantnerMagee:kibrantn/servicebus/track2-preview8-apiview-sync-changes
Nov 4, 2020
Merged

[ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender)#14502
KieranBrantnerMagee merged 13 commits intoAzure:masterfrom
KieranBrantnerMagee:kibrantn/servicebus/track2-preview8-apiview-sync-changes

Conversation

@KieranBrantnerMagee
Copy link
Member

Remove via_partition_key until we add transactions as a whole.
Rename properties to application_properties
Rename amqp_message to amqp_annotated_message for consistency

…eceiver/sender)

Remove via_partition_key until we add transactions as a whole.
Rename properties to application_properties
Rename amqp_message to amqp_annotated_message for consistency
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 14, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 14, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 14, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee KieranBrantnerMagee marked this pull request as ready for review October 15, 2020 21:21
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling self-assigned this Oct 30, 2020
yunhaoling
yunhaoling previously approved these changes Oct 30, 2020
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

KieranBrantnerMagee and others added 2 commits November 3, 2020 13:22
Rename Message->ServiceBusMessage in documentation to align with concurrent changes in master.

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Rename AMQPMessage to AMQPAnnotatedMessage to match property name and other SDKs.
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee KieranBrantnerMagee merged commit c0eab07 into Azure:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants