[Communication]: Migrated python identity tests to use ARM template#17890
Merged
lsundaralingam merged 4 commits intoAzure:masterfrom Apr 13, 2021
Merged
[Communication]: Migrated python identity tests to use ARM template#17890lsundaralingam merged 4 commits intoAzure:masterfrom
lsundaralingam merged 4 commits intoAzure:masterfrom
Conversation
ghost
added
the
Member
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
force-pushed
the
armTemplate
branch
from
e85a1e4 to
d7e40a5
Compare
Member
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lsundaralingam
requested review from
ankitarorabit,
beltr0n,
jbeauregardb and
sacheu
lsundaralingam
requested review from
a team,
danieljurek,
memontic-ms and
turalf
as code owners
lsundaralingam
changed the title
| def process_request(self, request): | ||
| import re | ||
| request.uri = re.sub('/identities/([^/?]+)', '/identities/sanitized', request.uri) | ||
| request.uri = re.sub('^(.*?)\\.communication.azure.com', 'https://sanitized.communication.azure.com', request.uri) |
Contributor
There was a problem hiding this comment.
Is there a way to just replace the regex instead of the whole string? The thing is that we may want to know if we tested against an INT resource or not even when the url was sanitized. As an example an INT URL may be something like: https://resourcename.int.communication.azure.com
There was a problem hiding this comment.
Yes, we need to consider the scenario for testing in INT environment.
Member
Author
There was a problem hiding this comment.
Good catch, I updated this to only sanitize the resource.
sacheu
approved these changes
Apr 12, 2021
| def process_request(self, request): | ||
| import re | ||
| request.uri = re.sub('/identities/([^/?]+)', '/identities/sanitized', request.uri) | ||
| request.uri = re.sub('^(.*?)\\.communication.azure.com', 'https://sanitized.communication.azure.com', request.uri) |
There was a problem hiding this comment.
Yes, we need to consider the scenario for testing in INT environment.
jbeauregardb
approved these changes
Apr 12, 2021
Contributor
jbeauregardb
left a comment
jbeauregardb
left a comment
There was a problem hiding this comment.
Looks great! Just left a comment regarding INT testing
Member
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
added a commit
that referenced
this pull request
Apr 15, 2021
…into protocol_base * 'master' of https://github.com/Azure/azure-sdk-for-python: (337 commits) [Container Registry] adding blurb about env vars to set (#17976) shared_requirements msrest verison update (#17938) Deprecate Azure-Synapse (#18027) add perf tests (#17519) Increment package version after release of azure-search-documents (#18017) [Communication]: Migrated python identity tests to use ARM template (#17890) [Container Registry] fixing up the test-resources-post script (#17883) [Communication]: Removed error code assertion from unauthorized phone number test (#17955) Add Conda Publishing (#17889) fix search fields (#18014) Sync eng/common directory with azure-sdk-tools for PR 1552 (#18011) [AppConfiguration] fix tests (#17917) updating generated code (#17874) Update document translation sample slug (#17989) update release date (#17988) [Communication] - SDK - Synced SMS and Phone Numbers shared folders (#17985) Remove unnecessary attribute access (#18007) [AutoRelease] t2-healthcareapis-2021-04-12-56802 (#17968) Revert retain. (#18004) Sync eng/common directory with azure-sdk-tools for PR 1553 (#18002) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.