[Communication] - SDK - Synced SMS and Phone Numbers shared folders#17985
Merged
jbeauregardb merged 3 commits intoAzure:masterfrom Apr 13, 2021
Merged
[Communication] - SDK - Synced SMS and Phone Numbers shared folders#17985jbeauregardb merged 3 commits intoAzure:masterfrom
jbeauregardb merged 3 commits intoAzure:masterfrom
Conversation
jbeauregardb
requested review from
a team,
ankitarorabit,
memontic-ms and
turalf
as code owners
ghost
added
the
Contributor
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DominikMe
previously requested changes
Apr 12, 2021
Member
DominikMe
left a comment
DominikMe
left a comment
There was a problem hiding this comment.
Thanks Jorge!
We also need to update setup.py to add typing-extensions as a dependency. See @annatisch 's PR as an example: #17912
Member
|
@jbeauregardb - there are other files in |
annatisch
reviewed
Apr 12, 2021
| from typing_extensions import Protocol, TypedDict | ||
|
|
||
| import msrest | ||
| from azure.core import CaseInsensitiveEnumMeta |
Member
There was a problem hiding this comment.
You will need to also bump the azure-core dependency to ensure CaseInsensitiveEnumMeta is present.
jbeauregardb
force-pushed
the
shared_sync
branch
from
e9fe63f to
6f9a9c0
Compare
Contributor
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jbeauregardb
force-pushed
the
shared_sync
branch
from
6f9a9c0 to
8f57ec1
Compare
DominikMe
reviewed
Apr 12, 2021
Member
DominikMe
left a comment
DominikMe
left a comment
There was a problem hiding this comment.
Unblocking my review to just Comment. Anna has this and you don't need my approval :-)
jbeauregardb
force-pushed
the
shared_sync
branch
from
8f57ec1 to
f793e30
Compare
annatisch
approved these changes
Apr 13, 2021
iscai-msft
added a commit
that referenced
this pull request
Apr 15, 2021
…into protocol_base * 'master' of https://github.com/Azure/azure-sdk-for-python: (337 commits) [Container Registry] adding blurb about env vars to set (#17976) shared_requirements msrest verison update (#17938) Deprecate Azure-Synapse (#18027) add perf tests (#17519) Increment package version after release of azure-search-documents (#18017) [Communication]: Migrated python identity tests to use ARM template (#17890) [Container Registry] fixing up the test-resources-post script (#17883) [Communication]: Removed error code assertion from unauthorized phone number test (#17955) Add Conda Publishing (#17889) fix search fields (#18014) Sync eng/common directory with azure-sdk-tools for PR 1552 (#18011) [AppConfiguration] fix tests (#17917) updating generated code (#17874) Update document translation sample slug (#17989) update release date (#17988) [Communication] - SDK - Synced SMS and Phone Numbers shared folders (#17985) Remove unnecessary attribute access (#18007) [AutoRelease] t2-healthcareapis-2021-04-12-56802 (#17968) Revert retain. (#18004) Sync eng/common directory with azure-sdk-tools for PR 1553 (#18002) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMS and Phone Numbers packages had an outdated version of their shared folders. Identity and chat were updated so I replicated the changes on these two other SDKs.