Skip to content

[storage/azure-storage-file-share] Fixed typos#25923

Merged
jalauzon-msft merged 5 commits intoAzure:mainfrom
KdHyeon0661:storage-cspell
Sep 7, 2022
Merged

[storage/azure-storage-file-share] Fixed typos#25923
jalauzon-msft merged 5 commits intoAzure:mainfrom
KdHyeon0661:storage-cspell

Conversation

@KdHyeon0661
Copy link
Copy Markdown
Contributor

@KdHyeon0661 KdHyeon0661 commented Aug 29, 2022

Description

closes #22680

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 29, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 29, 2022

Thank you for your contribution KdHyeon0661! We will review the pull request and get back to you soon.

jalauzon-msft
jalauzon-msft reviewed Aug 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KdHyeon0661 for your contribution! It is really great to get CSpell running on file-share finally! Just two minor comments for your consideration, thanks!

@KdHyeon0661 @wonhyeongseo
Apply the same change to _shared folder and edit some files
e40dd50 
Co-authored-by: wonhyeongseo <wonhseo@kakao.com>
@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Sep 1, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

jalauzon-msft
jalauzon-msft reviewed Sep 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KdHyeon0661, just a couple of small comments and this should be good. Looks like you'll also need to merge with main and resolve merge conflicts.

jalauzon-msft
jalauzon-msft approved these changes Sep 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KdHyeon0661! This looks good now. Can you just merge main and resolve the conflicts and then I can merge this.

@jalauzon-msft jalauzon-msft merged commit 0f8cb30 into Azure:main Sep 7, 2022
@jalauzon-msft
Copy link
Copy Markdown
Member

jalauzon-msft commented Sep 7, 2022

@KdHyeon0661, I pushed one small fix and merged this. Thanks for your contribution!

@jalauzon-msft jalauzon-msft mentioned this pull request Sep 7, 2022
Merged
6 tasks
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
@KdHyeon0661 @mccoyp
[storage/azure-storage-file-share] Fixed typos (Azure#25923)
5295293
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 25, 2023
@qingc @smile37773
CodeGen from PR 26231 in Azure/azure-rest-api-specs
aa8e0a9 
Add 2023-11-01-preview for appplatform (Azure#26231)

* Adds base for updating Microsoft.AppPlatform from version preview/2023-09-01-preview to version 2023-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fix go readme for asa api (Azure#25897)

* Update language specific readme.md for 2023-11-01-preview api version (Azure#25898)

* add more build result information in build resource (Azure#25930)

Co-authored-by: 刘清仪 <liuqingyi@liuqingyideMacBook-Pro.local>

* Add apiTryOutEnabledState for api protal (Azure#25923)

* Add swagger for Spring Cloud Gateway response cache (Azure#25924)

* Update appplatform.json (Azure#26234)

* Update appplatform.json

* Update appplatform.json

---------

Co-authored-by: Sandy Cai <sandy.caiqing@gmail.com>
Co-authored-by: Qingyi Liu <34502364+smile37773@users.noreply.github.com>
Co-authored-by: 刘清仪 <liuqingyi@liuqingyideMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

+1 more reviewer

@wonhyeongseo wonhyeongseo wonhyeongseo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage/azure-storage-file-share - cspell found spelling errors in source code

3 participants

@KdHyeon0661 @jalauzon-msft @wonhyeongseo