Open
Conversation
sumit-kalra
requested changes
May 25, 2022
| @@ -0,0 +1,80 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Please keep the filename consistent with existing naming scheme.
If current scheme doesn't seem okay to you then please change the scheme for all of them - but the customer should have a consistent experience.
| @@ -0,0 +1,80 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Can you please share details on how this has been tested?
For example, a customer would likely copy-paste this text; look for everything in angle brackets "<>" and replace with custom values. At that point the template should just work.
Has such a run been done on this quickstart example?
| "filters": [ | ||
| "exclude:$_.Title -like '*Preview*'", | ||
| "include:$true" | ||
| ], |
Member
There was a problem hiding this comment.
Please fix indentation.
Please check everywhere in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sumit-kalra please review