Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the filename consistent with existing naming scheme.
If current scheme doesn't seem okay to you then please change the scheme for all of them - but the customer should have a consistent experience.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share details on how this has been tested?
For example, a customer would likely copy-paste this text; look for everything in angle brackets "<>" and replace with custom values. At that point the template should just work.
Has such a run been done on this quickstart example?

"location": "westus2",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/<subscriptionID>/resourceGroups/<resourceGroupName>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<managedIdentity>": {}
}
},
"properties": {
"source": {
"type": "PlatformImage",
"publisher": "MicrosoftWindowsDesktop",
"offer": "Windows-10",
"sku": "20h2-pro",
"version": "latest"
},
"customize": [
{
"type": "WindowsRestart",
"restartCommand": "shutdown /f /r /t 0 /c \"packer restart\"",
"restartCheckCommand": "",
"restartTimeout": "20m",
"name": "Restart Max"
},
{
"type": "WindowsUpdate",
"searchCriteria": "IsInstalled=0",
"filters": [
"exclude:$_.Title -like '*Preview*'",
"include:$true"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation.
Please check everywhere in this file.

"updateLimit": 20
},
{
"type": "PowerShell",
"name": "PowerShell Cmds Customizer test",
"inline": [
"Write-Host HelloCustomize",
"New-Item -ItemType file c:\\example_1.txt",
"echo $?",
"Write-Host ByeCustomize"
]
}
],
"validate": {
"continueDistributeOnFailure": false,
"inVMValidations": [
{
"type": "PowerShell",
"name": "test PowerShell validator inline",
"inline": [
"Write-Host HelloValidate",
"New-Item -ItemType file c:\\valdnfile_1.txt",
"echo $?",
"Write-Host ByeValidate"
]
},
{
"type": "PowerShell",
"name": "<scriptName>",
"scriptUri": "<scriptUri>",
"validExitCodes": [
0,
1
]
}
]
},
"distribute": [
{
"type": "SharedImage",
"galleryImageId": "/subscriptions/<subscriptionID>/resourceGroups/<resourceGroupName>/providers/Microsoft.Compute/galleries/<sharedImageGalName>/images/<imageDefName>",
"runOutputName": "<runOutputName>",
"replicationRegions": [
"westus2"
]
}
]
}
}