Conversation
…patibility with Functions V1
…ined transitively
jviau
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces: #1020
As of recently, building the DTFx project failed with errors of the following kind:
The warnings were for:
In response, I made the following changes:
System.Data.SqlClientto4.8.5. This is only used in our test project, so it's safe.Newtonsoft.Jsonversion7.0.1dependency, which we use on thenet462TFM for backwards compatibility with Functions V1. I chose to suppress it to minimize breaking customers, and because Functions V1 is soon to be EOL.Newtonsoft.Jsonin our test projects, and in DTFx.AzureStorage. We already make receiveNewtonsoft.Jsontransitively, so having these dependencies only adds to our maintanance burden afaict.Note: the warnings still appear for DTFx.ServiceBus and DTFx.AzureServiceFabric. I did not apply my changes there as I know those projects are maintained by separate teams. I can contribute a PR to their projects once this one is merged.