Remove redundant Newtonsoft.JSON dependency across backends#1026
Merged
davidmrdavid merged 3 commits intomainfrom Mar 22, 2024
Merged
Remove redundant Newtonsoft.JSON dependency across backends#1026davidmrdavid merged 3 commits intomainfrom
davidmrdavid merged 3 commits intomainfrom
Conversation
davidmrdavid
changed the title
davidmrdavid
changed the title
Collaborator
Author
|
@shankarsama: is this change ok with you for DTFx.AzureServiceFabric? |
jviau
approved these changes
Jan 9, 2024
cgillum
approved these changes
Jan 9, 2024
…sto/patch-advisories-follow-up
Collaborator
Author
|
@shankarsama and I sync'ed offline, got approval to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to: #1023
As of recently, building the DTFx project failed with errors of the following kind:
"Warning as Error: Package has a known high severity vulnerability" and it points to this advisory: "
The warnings were for:
Newtonsoft.Json < 13.0.1, which linked to: GHSA-5crp-9r3c-p9vr
This issue was addressed (by supressing the warning) in DTFx.Core and DTFx.AzureStorage here: #1023. Suppressing the warning was chosen because it prevents breaking changes and the advisory is only triggered when customers have immensely nested objects, something they have direct control over.
In this PR, we address it across other backends by removing Newtonsoft.Json as a direct dependency of these backends. Moving forward, we'd obtain this dependency transitively from DTFx.Core, which reduces our dependency management burden.