test: E2E for Work-API #1 #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aagusuab
force-pushed
the
work-api-e2e-creation
branch
from
6f82913 to
c2e3f12
Compare
zhiying-lin
reviewed
Aug 29, 2022
Contributor
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
will discuss the comments with you offline. Thanks
aagusuab
force-pushed
the
work-api-e2e-creation
branch
from
1ac8bba to
4585147
Compare
zhiying-lin
reviewed
Aug 30, 2022
aagusuab
force-pushed
the
work-api-e2e-creation
branch
3 times, most recently
from
a3fc8cd to
36a2a5f
Compare
zhiying-lin
reviewed
Sep 2, 2022
zhiying-lin
reviewed
Sep 5, 2022
| gomega.Eventually(func() error { | ||
| _, err := RetrieveAppliedWork(workName, memberCluster) | ||
| return err | ||
| }, PollTimeout, PollInterval).Should(gomega.BeNil()) |
Contributor
There was a problem hiding this comment.
Looks like you have not revert the changes here.
If you need WaitAppliedWorkPresent, you could add it into the new helper.go directly.
aagusuab
force-pushed
the
work-api-e2e-creation
branch
3 times, most recently
from
378699b to
b807fcc
Compare
zhiying-lin
reviewed
Sep 7, 2022
zhiying-lin
reviewed
Sep 7, 2022
zhiying-lin
reviewed
Sep 8, 2022
zhiying-lin
reviewed
Sep 8, 2022
zhiying-lin
previously approved these changes
Sep 8, 2022
Contributor
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
one minor comment, others LGTM
zhiying-lin
reviewed
Sep 8, 2022
aagusuab
force-pushed
the
work-api-e2e-creation
branch
2 times, most recently
from
5233f67 to
27fcb32
Compare
1 task
zhiying-lin
reviewed
Sep 9, 2022
zhiying-lin
reviewed
Sep 9, 2022
zhiying-lin
previously approved these changes
Sep 9, 2022
Contributor
|
Hi Youn Jae, please update your PR description. Thanks |
aagusuab
force-pushed
the
work-api-e2e-creation
branch
from
e29c45b to
4a88163
Compare
zhiying-lin
previously approved these changes
Sep 13, 2022
Contributor
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
only have one question regarding annotation validation, thanks
ryanzhang-oss
approved these changes
Sep 13, 2022
michaelawyu
added a commit
to michaelawyu/fleet
that referenced
this pull request
Nov 19, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
-Creation of work with a manifest
-Validation of the created work
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer