test: More E2E tests for workload orchestration #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
ImpWorkloade2e
branch
2 times, most recently
from
22aa1fa to
5a701b7
Compare
Arvindthiru
force-pushed
the
ImpWorkloade2e
branch
7 times, most recently
from
ab43705 to
75e1c23
Compare
Arvindthiru
force-pushed
the
ImpWorkloade2e
branch
from
dde9fe2 to
d315345
Compare
Arvindthiru
force-pushed
the
ImpWorkloade2e
branch
from
d315345 to
8e05aaa
Compare
Arvindthiru
changed the title
Contributor
Author
|
Work API E2E test failures should be fixed after this PR gets merged #246 |
Arvindthiru
commented
Sep 8, 2022
| } | ||
|
|
||
| // WaitUpdateClusterRoleLabels waits for cluster role to be updated to new labels. | ||
| func WaitUpdateClusterRoleLabels(ctx context.Context, cluster framework.Cluster, clusterRole, newClusterRole *rbacv1.ClusterRole) { |
Contributor
Author
There was a problem hiding this comment.
Was planning on checking the whole object but it has a lot of fields which needs to be ignored to work
Arvindthiru
commented
Sep 8, 2022
| } | ||
|
|
||
| // WaitUpdateRoleRules waits for role to be updated to new rules. | ||
| func WaitUpdateRoleRules(ctx context.Context, cluster framework.Cluster, role, newRole *rbacv1.Role) { |
zhiying-lin
reviewed
Sep 9, 2022
Contributor
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
Hi Arvind, i believe there are some conflicts with #246 which is ready to merge.
Could you please rebase the code once the PR is merge?
In addition, could you please split the PR into smaller ones?
- one new test case per PR.
- split the refactor part into another PR, I notice that you're updating the util funcs to do the refactor. it helps to reduce distractions to review your new test case.
Thanks
1 task
Contributor
Author
|
Moving this to draft as I'm splitting this PR |
Contributor
|
no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer